Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/core/html/canvas/DataView.h

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/canvas/ArrayBufferView.idl ('k') | Source/core/html/canvas/DataView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/canvas/DataView.h
diff --git a/Source/core/html/canvas/DataView.h b/Source/core/html/canvas/DataView.h
index c0f48960f3307f77ba251db12e16bdf2758db2c3..a0dbd5c87df34dc23a8d0bdda37f4bd689294a33 100644
--- a/Source/core/html/canvas/DataView.h
+++ b/Source/core/html/canvas/DataView.h
@@ -26,21 +26,19 @@
#ifndef DataView_h
#define DataView_h
-#include "bindings/core/v8/ScriptWrappable.h"
#include "wtf/ArrayBufferView.h"
-#include "wtf/PassRefPtr.h"
namespace blink {
class ExceptionState;
-class DataView final : public ArrayBufferView, public ScriptWrappable {
- DEFINE_WRAPPERTYPEINFO();
+class DataView final : public ArrayBufferView {
public:
static PassRefPtr<DataView> create(unsigned length);
static PassRefPtr<DataView> create(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);
virtual unsigned byteLength() const override { return m_byteLength; }
+ virtual ViewType type() const override { return TypeDataView; }
int8_t getInt8(unsigned byteOffset, ExceptionState&);
uint8_t getUint8(unsigned byteOffset, ExceptionState&);
@@ -72,13 +70,6 @@ public:
void setFloat64(unsigned byteOffset, double value, ExceptionState& ec) { setFloat64(byteOffset, value, false, ec); }
void setFloat64(unsigned byteOffset, double value, bool littleEndian, ExceptionState&);
- virtual ViewType type() const override
- {
- return TypeDataView;
- }
-
- virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
-
protected:
virtual void neuter() override;
@@ -86,7 +77,7 @@ private:
DataView(PassRefPtr<ArrayBuffer>, unsigned byteOffset, unsigned byteLength);
template<typename T>
- inline bool beyondRange(unsigned byteOffset) const { return byteOffset >= m_byteLength || byteOffset + sizeof(T) > m_byteLength; }
+ bool beyondRange(unsigned byteOffset) const { return byteOffset >= m_byteLength || byteOffset + sizeof(T) > m_byteLength; }
template<typename T>
T getData(unsigned byteOffset, bool littleEndian, ExceptionState&) const;
« no previous file with comments | « Source/core/html/canvas/ArrayBufferView.idl ('k') | Source/core/html/canvas/DataView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698