Source/bindings/scripts/code_generator_v8.py - Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Synced. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.py

diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py

index 065873d90fd04bc2e58ffdbd3c2af4639b780cd0..b23f63f3d127eba4768229626ef010f676d28fd8 100644

--- a/Source/bindings/scripts/code_generator_v8.py

+++ b/Source/bindings/scripts/code_generator_v8.py

@@ -168,7 +168,10 @@ class CodeGeneratorV8(CodeGeneratorBase):

template_context = interface_context(interface)

# Add the include for interface itself

- template_context['header_includes'].add(interface_info['include_path'])

+ if IdlType(interface_name).is_typed_array:

+ template_context['header_includes'].add('core/dom/DOMTypedArray.h')

+ else:

+ template_context['header_includes'].add(interface_info['include_path'])

header_text, cpp_text = render_template(

interface_info, header_template, cpp_template, template_context)

header_path, cpp_path = self.output_paths(interface_name)