Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: Source/modules/websockets/DOMWebSocketTest.cpp

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/DOMWebSocketTest.cpp
diff --git a/Source/modules/websockets/DOMWebSocketTest.cpp b/Source/modules/websockets/DOMWebSocketTest.cpp
index 04b6d7c3f77ac53a64d56ece2e570e5869f0ef53..dc6e001f2e4536793359ab59e6ef60c7b94ef4c8 100644
--- a/Source/modules/websockets/DOMWebSocketTest.cpp
+++ b/Source/modules/websockets/DOMWebSocketTest.cpp
@@ -3,19 +3,17 @@
// found in the LICENSE file.
#include "config.h"
-
#include "modules/websockets/DOMWebSocket.h"
#include "bindings/core/v8/ExceptionState.h"
#include "bindings/core/v8/V8Binding.h"
+#include "core/dom/DOMTypedArray.h"
#include "core/dom/Document.h"
#include "core/dom/ExceptionCode.h"
#include "core/fileapi/Blob.h"
#include "core/frame/ConsoleTypes.h"
#include "core/testing/DummyPageHolder.h"
-#include "wtf/ArrayBuffer.h"
#include "wtf/OwnPtr.h"
-#include "wtf/Uint8Array.h"
#include "wtf/Vector.h"
#include "wtf/testing/WTFTestHelpers.h"
#include "wtf/text/WTFString.h"
@@ -546,7 +544,7 @@ TEST_F(DOMWebSocketTest, sendStringSuccess)
TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)
{
- RefPtr<ArrayBufferView> view = Uint8Array::create(8);
+ RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
{
InSequence s;
EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
@@ -565,7 +563,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenConnecting)
TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)
{
- RefPtr<ArrayBufferView> view = Uint8Array::create(8);
+ RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
{
InSequence s;
EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
@@ -587,7 +585,7 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosing)
TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)
{
Checkpoint checkpoint;
- RefPtr<ArrayBufferView> view = Uint8Array::create(8);
+ RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
{
InSequence s;
EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
@@ -609,11 +607,11 @@ TEST_F(DOMWebSocketTest, sendArrayBufferWhenClosed)
TEST_F(DOMWebSocketTest, sendArrayBufferSuccess)
{
- RefPtr<ArrayBufferView> view = Uint8Array::create(8);
+ RefPtr<DOMArrayBufferView> view = DOMUint8Array::create(8);
{
InSequence s;
EXPECT_CALL(channel(), connect(KURL(KURL(), "ws://example.com/"), String())).WillOnce(Return(true));
- EXPECT_CALL(channel(), send(Ref(*view->buffer()), 0, 8));
+ EXPECT_CALL(channel(), send(Ref(*view->view()->buffer()), 0, 8));
}
m_websocket->connect("ws://example.com/", Vector<String>(), m_exceptionState);

Powered by Google App Engine
This is Rietveld 408576698