bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Source/core/dom/DOMDataView.cpp

Index: Source/core/dom/DOMDataView.cpp
diff --git a/Source/core/dom/DOMDataView.cpp b/Source/core/dom/DOMDataView.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..2e1c53e52d9051675d22021abeb3f1a761dab419
--- /dev/null
+++ b/Source/core/dom/DOMDataView.cpp
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/dom/DOMDataView.h"
+
+#include "bindings/core/v8/DOMDataStore.h"
+#include "bindings/core/v8/V8ArrayBuffer.h"
+#include "bindings/core/v8/V8DOMWrapper.h"
+
+namespace blink {
+
+PassRefPtr<DOMDataView> DOMDataView::create(PassRefPtr<DOMArrayBuffer> prpBuffer, unsigned byteOffset, unsigned byteLength)
+{
+    RefPtr<DOMArrayBuffer> buffer = prpBuffer;
+    return adoptRef(new DOMDataView(DataView::create(buffer->buffer(), byteOffset, byteLength), buffer));
+}
+
+v8::Handle<v8::Object> DOMDataView::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    // It's possible that no one except for the new wrapper owns this object at
+    // this moment, so we have to prevent GC to collect this object until the
+    // object gets associated with the wrapper.
+    RefPtr<DOMDataView> protect(this);
+
+    ASSERT(!DOMDataStore::containsWrapperNonTemplate(this, isolate));
+
+    const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();
+    RefPtr<DOMArrayBuffer> buffer = this->buffer();
+    v8::Local<v8::Value> v8Buffer = toV8(buffer.release(), creationContext, isolate);

[haraken, 2014/10/16 05:41:42]

You can just write toV8(buffer(), creationContext, isolate) here.

[Yuki, 2014/10/16 14:21:51]

Done.

+    ASSERT(v8Buffer->IsArrayBuffer());
+
+    v8::Handle<v8::Object> wrapper = v8::DataView::New(v8Buffer.As<v8::ArrayBuffer>(), byteOffset(), byteLength());
+
+    wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate);

[haraken, 2014/10/16 05:41:42]

I think you can remove this.

[Yuki, 2014/10/16 14:21:51]

Done.

+    return associateWithWrapper(wrapperTypeInfo, wrapper, isolate);
+}
+
+v8::Handle<v8::Object> DOMDataView::associateWithWrapper(const WrapperTypeInfo* wrapperTypeInfo, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
+{
+    return V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperTypeInfo, wrapper, isolate);
+}
+
+} // namespace blink