Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2639)

Unified Diff: Source/web/WebArrayBufferConverter.cpp

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Win GPU tests (DOMDataView). Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebArrayBufferConverter.cpp
diff --git a/Source/web/WebArrayBufferConverter.cpp b/Source/web/WebArrayBufferConverter.cpp
index 58d7a52af7b6676c9ab94decb9ce4e83ca8f4fb1..54937d4fa5d7eee819466a18738daa1a32fecf95 100644
--- a/Source/web/WebArrayBufferConverter.cpp
+++ b/Source/web/WebArrayBufferConverter.cpp
@@ -31,9 +31,7 @@
#include "config.h"
#include "public/web/WebArrayBufferConverter.h"
-#include "bindings/core/v8/custom/V8ArrayBufferCustom.h"
-#include "wtf/ArrayBuffer.h"
-#include "wtf/PassOwnPtr.h"
+#include "bindings/core/v8/V8ArrayBuffer.h"
namespace blink {
@@ -41,16 +39,16 @@ v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer,
{
if (!buffer)
return v8::Handle<v8::Value>();
- return toV8(*buffer, creationContext, isolate);
+ RefPtr<DOMArrayBuffer> arrayBuffer = DOMArrayBuffer::create(*buffer);
+ return toV8(arrayBuffer, creationContext, isolate);
haraken 2014/10/14 15:11:20 arrayBuffer.release()
Yuki 2014/10/15 09:35:24 Done.
}
WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value, v8::Isolate* isolate)
{
if (!V8ArrayBuffer::hasInstance(value, isolate))
return 0;
- ArrayBuffer* buffer = V8ArrayBuffer::toImpl(value->ToObject());
- return new WebArrayBuffer(buffer);
+ DOMArrayBuffer* buffer = V8ArrayBuffer::toImpl(value->ToObject());
+ return new WebArrayBuffer(buffer->buffer());
}
} // namespace blink
-

Powered by Google App Engine
This is Rietveld 408576698