bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Source/core/dom/DOMDataView.cpp

Index: Source/core/dom/DOMDataView.cpp
diff --git a/Source/core/dom/DOMDataView.cpp b/Source/core/dom/DOMDataView.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..82b31d35e37e20743730898bcbac6565f909d643
--- /dev/null
+++ b/Source/core/dom/DOMDataView.cpp
@@ -0,0 +1,48 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/dom/DOMDataView.h"
+
+#include "bindings/core/v8/DOMDataStore.h"
+#include "bindings/core/v8/V8ArrayBuffer.h"
+#include "bindings/core/v8/V8DOMWrapper.h"
+
+namespace blink {
+
+PassRefPtr<DOMDataView> DOMDataView::create(PassRefPtr<DOMArrayBuffer> buffer, unsigned byteOffset, unsigned byteLength)

[haraken, 2014/10/14 15:11:19]

buffer => prpBuffer (We normally use prpXXX)

[Yuki, 2014/10/15 09:35:24]

Done.

+{
+    // Don't use |buffer| directly here to avoid passing PassRefPtr to another
+    // PassRefPtr, which invalidates the original PassRefPtr.
+    // See PassRefPtr::PassRefPtr(const PassRefPtr&).
+    RefPtr<DOMArrayBuffer> buf = buffer;

[haraken, 2014/10/14 15:11:19]

buf => buffer

[Yuki, 2014/10/15 09:35:24]

Done.

+    return adoptRef(new DOMDataView(DataView::create(buf->buffer(), byteOffset, byteLength), buf));
+}
+
+v8::Handle<v8::Object> DOMDataView::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    // It's possible that no one except for the new wrapper owns this object at
+    // this moment, so we have to prevent GC to collect this object until the
+    // object gets associated with the wrapper.
+    RefPtrWillBeRawPtr<DOMDataView> protect(this);

[haraken, 2014/10/14 15:11:19]

DOMDataView is not yet on Oilpan's heap, so this should be RefPtr.

[Yuki, 2014/10/15 09:35:24]

Done.

+
+    ASSERT(!DOMDataStore::containsWrapperNonTemplate(this, isolate));
+
+    const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();
+    RefPtr<DOMArrayBuffer> buffer = this->buffer();
+    v8::Local<v8::Value> v8Buffer = toV8(buffer.get(), creationContext, isolate);

[haraken, 2014/10/14 15:11:19]

buffer.get() => buffer.release()

[Yuki, 2014/10/15 09:35:24]

Done.

+    ASSERT(v8Buffer->IsArrayBuffer());
+
+    v8::Handle<v8::Object> wrapper = v8::DataView::New(v8Buffer.As<v8::ArrayBuffer>(), byteOffset(), byteLength());
+
+    wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate);
+    return associateWithWrapper(wrapperTypeInfo, wrapper, isolate);
+}
+
+v8::Handle<v8::Object> DOMDataView::associateWithWrapper(const WrapperTypeInfo* wrapperTypeInfo, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
+{
+    return V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperTypeInfo, wrapper, isolate);
+}
+
+} // namespace blink