bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Source/bindings/scripts/v8_interface.py

Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 9cb32a59af27c5984346bf23bf7c82a820cc6830..220322382ef18518530e92e94731bd7af8f3c065 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -82,6 +82,23 @@ def interface_context(interface):
         header_includes.update(v8_types.includes_for_interface(parent_interface))
     extended_attributes = interface.extended_attributes
 
+    is_array_type = IdlType(interface.name).is_array_element_type

[haraken, 2014/10/14 15:11:18]

Can we use interface.idl_type.is_array_element_type ?

[Yuki, 2014/10/15 09:35:23]

|interface| of type IdlInterface does not have |idl_type|.
Would you like me to add idl_type into IdlInterface?
Or is it okay with the current code?

[haraken, 2014/10/16 05:41:40]

I think it's better to introduce interface.idl_type.

[Yuki, 2014/10/16 14:21:50]

Done.

+    is_typed_array_type = IdlType(interface.name).is_typed_array_element_type

[haraken, 2014/10/14 15:11:18]

Ditto.

[Yuki, 2014/10/16 14:21:50]

Done.

+    if is_array_type:
+        includes.add('bindings/core/v8/V8ArrayBuffer.h')
+    if interface.name == 'ArrayBufferView':
+        includes.update((
+            'bindings/core/v8/V8Int8Array.h',
+            'bindings/core/v8/V8Int16Array.h',
+            'bindings/core/v8/V8Int32Array.h',
+            'bindings/core/v8/V8Uint8Array.h',
+            'bindings/core/v8/V8Uint8ClampedArray.h',
+            'bindings/core/v8/V8Uint16Array.h',
+            'bindings/core/v8/V8Uint32Array.h',
+            'bindings/core/v8/V8Float32Array.h',
+            'bindings/core/v8/V8Float64Array.h',
+            'bindings/core/v8/V8DataView.h'))
+
     # [ActiveDOMObject]
     is_active_dom_object = 'ActiveDOMObject' in extended_attributes
 
@@ -157,12 +174,15 @@ def interface_context(interface):
         'header_includes': header_includes,
         'interface_name': interface.name,
         'is_active_dom_object': is_active_dom_object,
+        'is_array_type': is_array_type,
         'is_check_security': is_check_security,
         'is_dependent_lifetime': is_dependent_lifetime,
         'is_event_target': inherits_interface(interface.name, 'EventTarget'),
         'is_exception': interface.is_exception,
         'is_node': inherits_interface(interface.name, 'Node'),
         'is_script_wrappable': is_script_wrappable,
+        'is_typed_array_type': is_typed_array_type,
+        'is_v8object': not is_array_type,

[haraken, 2014/10/14 15:11:18]

"v8object" sounds a bit too general to me. I'd just remove this variable since
'not is_array_type' will just work in template files.

[Yuki, 2014/10/15 09:35:23]

is_v8object (meant for v8::Object) is used at places where it's important that
the object is bound to v8::Object, and where it's not important that the object
is not an array buffer or its view.

I'm worrying that it would be confusing in future when we need to care about
v8::Foo which is neither of v8::Object nor v8::ArrayBuffer, etc.

I've added a comment about what v8object is meant.

         'iterator_method': iterator_method,
         'lifetime': 'Dependent'
             if (has_visit_dom_wrapper or