bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Source/modules/webmidi/MIDIOutput.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 171 matching lines @@
 MIDIOutput::MIDIOutput(MIDIAccess* access, unsigned portIndex, const String& id, const String& manufacturer, const String& name, const String& version)
     : MIDIPort(access, id, manufacturer, name, MIDIPortTypeOutput, version)
     , m_portIndex(portIndex)
 {
 }
 
 MIDIOutput::~MIDIOutput()
 {
 }
 
+void MIDIOutput::send(DOMUint8Array* array, double timestamp, ExceptionState& exceptionState)
+{
+    if (!array)
+        return;
+
+    send(array->view(), timestamp, exceptionState);
+}
+
 void MIDIOutput::send(Uint8Array* array, double timestamp, ExceptionState& exceptionState)

[haraken, 2014/10/14 15:11:19]

Do we need both MIDIOutput(DOMUint8Array*, ...) and MIDIOutput(Uint8Array*,
...)?

[Yuki, 2014/10/15 09:35:24]

There are two types of callers.

Auto-generated V8T passes DOMUint8Array* because the IDL file says that send()
receives Uint8Array which is implementedAs=DOMUint8Array.

On the other hand, the existing Blink-internal calls to send() pass Uint8Array*
as same as before.

 {
     if (timestamp == 0.0)
         timestamp = now(executionContext());
 
     if (!array)
         return;
 
     if (MessageValidator::validate(array, exceptionState, midiAccess()->sysexEnabled()))
         midiAccess()->sendMIDIData(m_portIndex, array->data(), array->length(), timestamp);
 }
@@ skipping 10 matching lines @@
             exceptionState.throwTypeError("The value at index " + String::number(i) + " (" + String::number(unsignedData[i]) + ") is greater than 0xFF.");
             return;
         }
         unsigned char value = unsignedData[i] & 0xff;
         array->set(i, value);
     }
 
     send(array.get(), timestamp, exceptionState);
 }
 
-void MIDIOutput::send(Uint8Array* data, ExceptionState& exceptionState)
+void MIDIOutput::send(DOMUint8Array* data, ExceptionState& exceptionState)
 {
     send(data, 0.0, exceptionState);
 }
 
 void MIDIOutput::send(Vector<unsigned> unsignedData, ExceptionState& exceptionState)
 {
     send(unsignedData, 0.0, exceptionState);
 }
 
 void MIDIOutput::trace(Visitor* visitor)
 {
     MIDIPort::trace(visitor);
 }
 
 } // namespace blink