Source/core/dom/DOMArrayPiece.h - Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/dom/DOMArrayPiece.h

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed Win GPU tests (DOMDataView). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DOMArrayPiece_h

	6 #define DOMArrayPiece_h

	7

	8 #include "core/dom/DOMArrayBuffer.h"

	9 #include "core/dom/DOMArrayBufferView.h"

	10 #include "wtf/ArrayPiece.h"

	11

	12 namespace blink {

	13

	14 class DOMArrayPiece : public WTF::ArrayPiece {

	15 public:

	16 DOMArrayPiece(DOMArrayBuffer* buffer)
	haraken 2014/10/14 15:11:19 Add 'explicit'. Add 'explicit'. Yuki 2014/10/15 09:35:24 We want the implicit conversion here, as same as W Show quoted text On 2014/10/14 15:11:19, haraken wrote: > > Add 'explicit'. We want the implicit conversion here, as same as WTF::ArrayPiece and StringPiece.
	17 : ArrayPiece(buffer->buffer()) { }

	18 DOMArrayPiece(DOMArrayBufferView* view)
	haraken 2014/10/14 15:11:19 Add 'explicit'. Add 'explicit'.
	19 : ArrayPiece(view->view()) { }

	20 };

	21

	22 } // namespace blink

	23

	24 #endif // DOMArrayPiece_h

OLD	NEW