Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 606653002: Let --js-flags work when Harmony is enabled in about:flags (reland) (Closed)

Created:
6 years, 2 months ago by Erik Corry Chromium.org
Modified:
6 years, 2 months ago
CC:
Alexei Svitkine (slow), chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Let --js-flags work when Harmony is enabled in about:flags (reland) BUG= Committed: https://crrev.com/b251cb9f6c2db0c48785125af5e629e7acfc5199 Cr-Commit-Position: refs/heads/master@{#296834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Erik Corry
6 years, 2 months ago (2014-09-25 12:32:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-25 12:33:31 UTC) #4
Erik Corry
Adding asvitkine as histograms reviewer
6 years, 2 months ago (2014-09-25 12:37:32 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-25 15:11:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606653002/1
6 years, 2 months ago (2014-09-25 21:11:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as d7479d8e3bf27589531376c08b235e41668643d5
6 years, 2 months ago (2014-09-25 23:49:02 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:49:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b251cb9f6c2db0c48785125af5e629e7acfc5199
Cr-Commit-Position: refs/heads/master@{#296834}

Powered by Google App Engine
This is Rietveld 408576698