[WebView] Create PowerSaveBlocker for fullscreen video.

content/browser/android/content_video_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_video_view.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 244 matching lines @@
       env,
       Java_ContentVideoView_createContentVideoView(
           env,
           content_view_core->GetContext().obj(),
           reinterpret_cast<intptr_t>(this),
           content_view_core->GetContentVideoViewClient().obj(),
           legacyMode).obj());
 }
 
 void ContentVideoView::CreatePowerSaveBlocker() {
-  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kDisableOverlayFullscreenVideoSubtitle)) {
-    return;
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[Ignacio Solla, 2014/09/25 10:36:02]

Some context: kDisableOverlayFullscreenVideoSubtitle was used by embedders that
did not support html5 video controls. Both Clank and WebView now support html5
video controls, so I will be removing this flag very soon. The problem is that
during the transition in the WebView we inadvertently broke power save in
fullscreen, because the fullscreen power-save feature was incorrectly associated
with the html5 controls feature.

+      switches::kEnableContentVideoViewPowerSaveBlocker)) {
+    // In fullscreen Clank reuses the power save blocker attached to the
+    // container view that was created for embedded video. The WebView cannot
+    // reuse that so we create a new blocker instead.
+    if (power_save_blocker_) return;
+
+    power_save_blocker_ = PowerSaveBlocker::Create(
+        PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep,
+        "Playing video").Pass();
+    static_cast<PowerSaveBlockerImpl*>(power_save_blocker_.get())->
+        InitDisplaySleepBlocker(GetNativeView());
   }
-
-  if (power_save_blocker_) return;
-
-  power_save_blocker_ = PowerSaveBlocker::Create(
-      PowerSaveBlocker::kPowerSaveBlockPreventDisplaySleep,
-      "Playing video").Pass();
-  static_cast<PowerSaveBlockerImpl*>(power_save_blocker_.get())->
-      InitDisplaySleepBlocker(GetNativeView());
 }
 
 }  // namespace content