Issue 60663004: Roll Skia DEPS to r12146

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60663004: Roll Skia DEPS to r12146 (Closed)

Created:
7 years, 1 month ago by robertphillips

Modified:
7 years, 1 month ago

Reviewers:
bsalomon, rmistry, reed1

CC:
chromium-reviews, skia-team_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Roll Skia DEPS to r12146 R=rmistry@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233259

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

I believe this is 'good'. The discrepancies between the roll and control are: android_dbg roll: ...

7 years, 1 month ago (2013-11-06 12:51:31 UTC) #2

I believe this is 'good'. The discrepancies between the roll and control are:

android_dbg
   roll:    
            slave_steps
                preamble
            chromiumtestshell_instrumentation_tests 
   control: 
            green

linux
   roll:    
            buildrunner_tests
                preamble
            check_deps - not Skia-related ************************************
            ui_unittests failed 3
                Fonts_GetHeight_GetBaseline
                SetFontList
                StringSizeRespectsFontListMetrics
   control: 
            buildrunner_tests
                preamble
            ui_unittests failed 3
                Fonts_GetHeight_GetBaseline
                SetFontList
                StringSizeRespectsFontListMetrics

linux_chromeos
   roll:    
            buildrunner_tests
                preamble
            browser_tests did not complete failed 6
                ExternalData
                AutolaunchWarningConfirm
                InstallAndLaunchApp
                LaunchAppNetworkDownConfigureNotAllowed
                DragOffShelf
                PostMessage
   control: 
            green

win
   roll:    
            telemetry_unittests failed 1
                testGetDOMStats **********************************************
            telemetry_perf_unittests failed 2
                testCacheHandled
                testCalcResultsTraceEvents
            lost bot *********************************************************
   control: 
            buildrunner_tests
                preamble
            telemetry_perf_unittests failed 2
                testCacheHandled
                testCalcResultsTraceEvents
            content_browsertests did not complete failed 3
                BackForwardNotStale
                LimitTotal
                PassMessagePortToSharedWorkerDontWaitForConnect

win_layout
   roll:    
            webkit_tests 169 fixable (0 skipped) failed 2
                attributes.html 
                repeatn-event-1d.svg *****************************************
   control: 
            webkit_tests 170 fixable (0 skipped) failed 2
                attributes.html 
                manipulation.html

robertphillips

7 years, 1 month ago (2013-11-06 12:57:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r233259 (presubmit successful).

Expand Messages | Collapse Messages