Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: PRESUBMIT.py

Issue 606563004: Remove presubmit exception for the test runner library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 10 matching lines...) Expand all
21 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*", 21 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",
22 r"^skia[\\\/].*", 22 r"^skia[\\\/].*",
23 r"^v8[\\\/].*", 23 r"^v8[\\\/].*",
24 r".*MakeFile$", 24 r".*MakeFile$",
25 r".+_autogen\.h$", 25 r".+_autogen\.h$",
26 r".+[\\\/]pnacl_shim\.c$", 26 r".+[\\\/]pnacl_shim\.c$",
27 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$", 27 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$",
28 r"^chrome[\\\/]browser[\\\/]resources[\\\/]pdf[\\\/]index.js" 28 r"^chrome[\\\/]browser[\\\/]resources[\\\/]pdf[\\\/]index.js"
29 ) 29 )
30 30
31 # TestRunner and NetscapePlugIn library is temporarily excluded from pan-project 31 # The NetscapePlugIn library is excluded from pan-project as it will soon
32 # checks until it's transitioned to chromium coding style. 32 # be deleted together with the rest of the NPAPI and it's not worthwhile to
33 # update the coding style until then.
33 _TESTRUNNER_PATHS = ( 34 _TESTRUNNER_PATHS = (
34 r"^content[\\\/]shell[\\\/]renderer[\\\/]test_runner[\\\/].*",
35 r"^content[\\\/]shell[\\\/]tools[\\\/]plugin[\\\/].*", 35 r"^content[\\\/]shell[\\\/]tools[\\\/]plugin[\\\/].*",
36 ) 36 )
37 37
38 # Fragment of a regular expression that matches C++ and Objective-C++ 38 # Fragment of a regular expression that matches C++ and Objective-C++
39 # implementation files. 39 # implementation files.
40 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$' 40 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$'
41 41
42 # Regular expression that matches code only used for test binaries 42 # Regular expression that matches code only used for test binaries
43 # (best effort). 43 # (best effort).
44 _TEST_CODE_EXCLUDED_PATHS = ( 44 _TEST_CODE_EXCLUDED_PATHS = (
(...skipping 1602 matching lines...) Expand 10 before | Expand all | Expand 10 after
1647 builders.extend(['cros_x86']) 1647 builders.extend(['cros_x86'])
1648 1648
1649 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1649 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1650 # unless they're .gyp(i) files as changes to those files can break the gyp 1650 # unless they're .gyp(i) files as changes to those files can break the gyp
1651 # step on that bot. 1651 # step on that bot.
1652 if (not all(re.search('^chrome', f) for f in files) or 1652 if (not all(re.search('^chrome', f) for f in files) or
1653 any(re.search('\.gypi?$', f) for f in files)): 1653 any(re.search('\.gypi?$', f) for f in files)):
1654 builders.extend(['android_aosp']) 1654 builders.extend(['android_aosp'])
1655 1655
1656 return GetDefaultTryConfigs(builders) 1656 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698