Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 606553002: Adds some UMA log entries for input methods. (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds some UMA log entries for input methods. BUG=367631 TEST=Verified with IME extensions on linux_chromeos. NOTRY=true Committed: https://crrev.com/5c629c43410d126eef4c2c64b3cd1be648a74476 Cr-Commit-Position: refs/heads/master@{#296966}

Patch Set 1 #

Total comments: 10

Patch Set 2 : revised per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Shu Chen
isherman@, can you please help review this cl? thanks!
6 years, 2 months ago (2014-09-25 05:55:40 UTC) #2
Ilya Sherman
https://codereview.chromium.org/606553002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/606553002/diff/1/tools/metrics/histograms/histograms.xml#newcode9912 tools/metrics/histograms/histograms.xml:9912: + from 0 to 2. Are there any meaningful ...
6 years, 2 months ago (2014-09-25 22:25:34 UTC) #3
Shu Chen
Thanks for your review, please take another look. https://codereview.chromium.org/606553002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/606553002/diff/1/tools/metrics/histograms/histograms.xml#newcode9912 tools/metrics/histograms/histograms.xml:9912: + ...
6 years, 2 months ago (2014-09-26 14:22:05 UTC) #4
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-09-26 17:10:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606553002/20001
6 years, 2 months ago (2014-09-26 17:12:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8b9b90e2a8b3cb0d022c1b8dfb5589a417041b4f
6 years, 2 months ago (2014-09-26 17:13:21 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 17:14:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c629c43410d126eef4c2c64b3cd1be648a74476
Cr-Commit-Position: refs/heads/master@{#296966}

Powered by Google App Engine
This is Rietveld 408576698