chrome/browser/first_run/upgrade_util_win.cc - Issue 606473002: Remove implicit HANDLE conversions from chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/upgrade_util_win.cc

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove spurious file and fix indent (+rebase) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/first_run/upgrade_util_win.cc

diff --git a/chrome/browser/first_run/upgrade_util_win.cc b/chrome/browser/first_run/upgrade_util_win.cc

index 2334500b55b46a9f3daff0f202eb7f4bc64502d9..55c327c0c102542bc068d1eb5feae444c3a1ff89 100644

--- a/chrome/browser/first_run/upgrade_util_win.cc

+++ b/chrome/browser/first_run/upgrade_util_win.cc

@@ -264,7 +264,7 @@ bool SwapNewChromeExeIfPresent() {

options.start_hidden = true;

if (base::LaunchProcess(rename_cmd, options, &handle)) {

DWORD exit_code;

- ::GetExitCodeProcess(handle, &exit_code);

+ ::GetExitCodeProcess(handle.Get(), &exit_code);

if (exit_code == installer::RENAME_SUCCESSFUL)

return true;

}