Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 606443004: Revert of Revert of Fix doodle verification URL. (Closed)

Created:
6 years, 3 months ago by newt (away)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Fix doodle verification URL. (patchset #1 id:1 of https://codereview.chromium.org/599243002/) Reason for revert: The original revert was a mistake. Relanding this with no changed. Original issue's description: > Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/) > > Reason for revert: > Caused test failure: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 > > Original issue's description: > > Fix doodle verification URL. > > > > When verifying that the cached doodle is still valid, we load the doodle > > URL and append the query param "async=es_dfp:<fingerprint>". Previously, > > the ":" was being escape to "%3A", causing the server to respond with a > > 400 error. This mollifies the server by keeping the colon unescaped. > > > > BUG=413845 > > > > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c > > Cr-Commit-Position: refs/heads/master@{#296512} > > TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=413845 > > Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051 > Cr-Commit-Position: refs/heads/master@{#296546} TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,groby@chromium.org,jiayl@chromium.org NOTREECHECKS=true NOTRY=true BUG=413845 Committed: https://crrev.com/ac852f9a9158369fd38fed3d29d9329596e1036a Cr-Commit-Position: refs/heads/master@{#296556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M components/search_provider_logos/google_logo_api.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
newt (away)
Created Revert of Revert of Fix doodle verification URL.
6 years, 3 months ago (2014-09-24 23:18:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606443004/1
6 years, 3 months ago (2014-09-24 23:20:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6550df64d87da1a9330af5bd6b1f692b6553cec6
6 years, 3 months ago (2014-09-24 23:21:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:22:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac852f9a9158369fd38fed3d29d9329596e1036a
Cr-Commit-Position: refs/heads/master@{#296556}

Powered by Google App Engine
This is Rietveld 408576698