DescriptionRevert of Revert of Fix doodle verification URL. (patchset #1 id:1 of https://codereview.chromium.org/599243002/)
Reason for revert:
The original revert was a mistake. Relanding this with no changed.
Original issue's description:
> Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)
>
> Reason for revert:
> Caused test failure:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > Fix doodle verification URL.
> >
> > When verifying that the cached doodle is still valid, we load the doodle
> > URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> > the ":" was being escape to "%3A", causing the server to respond with a
> > 400 error. This mollifies the server by keeping the colon unescaped.
> >
> > BUG=413845
> >
> > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> > Cr-Commit-Position: refs/heads/master@{#296512}
>
> TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=413845
>
> Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051
> Cr-Commit-Position: refs/heads/master@{#296546}
TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,groby@chromium.org,jiayl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845
Committed: https://crrev.com/ac852f9a9158369fd38fed3d29d9329596e1036a
Cr-Commit-Position: refs/heads/master@{#296556}
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|