Issue 606443003: Remove implicit HANDLE conversions from cloud_print.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 606443003: Remove implicit HANDLE conversions from cloud_print. (Closed)

Created:
6 years, 2 months ago by rvargas (doing something else)

Modified:
6 years, 2 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove implicit HANDLE conversions from cloud_print. BUG=416722 R=gene@chromium.org Committed: https://crrev.com/2ca0f9c9a788a2b16b486a26937818ff02ad21c1 Cr-Commit-Position: refs/heads/master@{#296582}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -25 lines)			Patch
M	cloud_print/service/win/chrome_launcher.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	cloud_print/service/win/service_controller.cc	View	8 chunks	+17 lines, -15 lines	0 comments	Download
M	cloud_print/service/win/service_listener.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cloud_print/service/win/setup_listener.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cloud_print/virtual_driver/win/install/setup.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cloud_print/virtual_driver/win/port_monitor/port_monitor.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606443003/1

6 years, 2 months ago (2014-09-24 23:52:11 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as e83278e5ee70130fd8b44502a2a2450ef4f32620

6 years, 2 months ago (2014-09-25 00:06:38 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 00:07:33 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2ca0f9c9a788a2b16b486a26937818ff02ad21c1
Cr-Commit-Position: refs/heads/master@{#296582}