Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: sandbox/win/src/handle_closer_test.cc

Issue 606443002: Remove implicit HANDLE conversions from sandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/win/src/broker_services.cc ('k') | sandbox/win/src/handle_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/handle_closer_test.cc
diff --git a/sandbox/win/src/handle_closer_test.cc b/sandbox/win/src/handle_closer_test.cc
index 2082baaec4692f50797ef735276e5bc6a4400fbc..2f5890d537e73bcf418ab30455646d797352a996 100644
--- a/sandbox/win/src/handle_closer_test.cc
+++ b/sandbox/win/src/handle_closer_test.cc
@@ -29,9 +29,9 @@ HANDLE GetMarkerFile(const wchar_t *extension) {
OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL));
CHECK(module.IsValid());
FILETIME timestamp;
- CHECK(::GetFileTime(module, &timestamp, NULL, NULL));
+ CHECK(::GetFileTime(module.Get(), &timestamp, NULL, NULL));
marker_path += base::StringPrintf(L"%08x%08x%08x",
- ::GetFileSize(module, NULL),
+ ::GetFileSize(module.Get(), NULL),
timestamp.dwLowDateTime,
timestamp.dwHighDateTime);
marker_path += extension;
@@ -115,7 +115,7 @@ TEST(HandleCloserTest, CheckForMarkerFiles) {
base::string16 handle_name;
base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i]));
CHECK(marker.IsValid());
- CHECK(sandbox::GetHandleName(marker, &handle_name));
+ CHECK(sandbox::GetHandleName(marker.Get(), &handle_name));
command += (L" ");
command += handle_name;
}
@@ -135,7 +135,7 @@ TEST(HandleCloserTest, CloseMarkerFiles) {
base::string16 handle_name;
base::win::ScopedHandle marker(GetMarkerFile(kFileExtensions[i]));
CHECK(marker.IsValid());
- CHECK(sandbox::GetHandleName(marker, &handle_name));
+ CHECK(sandbox::GetHandleName(marker.Get(), &handle_name));
CHECK_EQ(policy->AddKernelObjectToClose(L"File", handle_name.c_str()),
SBOX_ALL_OK);
command += (L" ");
« no previous file with comments | « sandbox/win/src/broker_services.cc ('k') | sandbox/win/src/handle_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698