Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Side by Side Diff: sandbox/win/src/handle_dispatcher.cc

Issue 606443002: Remove implicit HANDLE conversions from sandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sandbox/win/src/handle_closer_test.cc ('k') | sandbox/win/src/handle_policy_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sandbox/win/src/handle_dispatcher.h" 5 #include "sandbox/win/src/handle_dispatcher.h"
6 6
7 #include "base/win/scoped_handle.h" 7 #include "base/win/scoped_handle.h"
8 #include "sandbox/win/src/handle_interception.h" 8 #include "sandbox/win/src/handle_interception.h"
9 #include "sandbox/win/src/handle_policy.h" 9 #include "sandbox/win/src/handle_policy.h"
10 #include "sandbox/win/src/ipc_tags.h" 10 #include "sandbox/win/src/ipc_tags.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 options &= ~DUPLICATE_CLOSE_SOURCE; 59 options &= ~DUPLICATE_CLOSE_SOURCE;
60 base::win::ScopedHandle handle(handle_temp); 60 base::win::ScopedHandle handle(handle_temp);
61 61
62 // Get the object type (32 characters is safe; current max is 14). 62 // Get the object type (32 characters is safe; current max is 14).
63 BYTE buffer[sizeof(OBJECT_TYPE_INFORMATION) + 32 * sizeof(wchar_t)]; 63 BYTE buffer[sizeof(OBJECT_TYPE_INFORMATION) + 32 * sizeof(wchar_t)];
64 OBJECT_TYPE_INFORMATION* type_info = 64 OBJECT_TYPE_INFORMATION* type_info =
65 reinterpret_cast<OBJECT_TYPE_INFORMATION*>(buffer); 65 reinterpret_cast<OBJECT_TYPE_INFORMATION*>(buffer);
66 ULONG size = sizeof(buffer) - sizeof(wchar_t); 66 ULONG size = sizeof(buffer) - sizeof(wchar_t);
67 NTSTATUS error = 67 NTSTATUS error =
68 QueryObject(handle, ObjectTypeInformation, type_info, size, &size); 68 QueryObject(handle.Get(), ObjectTypeInformation, type_info, size, &size);
69 if (!NT_SUCCESS(error)) { 69 if (!NT_SUCCESS(error)) {
70 ipc->return_info.nt_status = error; 70 ipc->return_info.nt_status = error;
71 return false; 71 return false;
72 } 72 }
73 type_info->Name.Buffer[type_info->Name.Length / sizeof(wchar_t)] = L'\0'; 73 type_info->Name.Buffer[type_info->Name.Length / sizeof(wchar_t)] = L'\0';
74 74
75 CountedParameterSet<HandleTarget> params; 75 CountedParameterSet<HandleTarget> params;
76 params[HandleTarget::NAME] = ParamPickerMake(type_info->Name.Buffer); 76 params[HandleTarget::NAME] = ParamPickerMake(type_info->Name.Buffer);
77 params[HandleTarget::TARGET] = ParamPickerMake(target_process_id); 77 params[HandleTarget::TARGET] = ParamPickerMake(target_process_id);
78 78
79 EvalResult eval = policy_base_->EvalPolicy(IPC_DUPLICATEHANDLEPROXY_TAG, 79 EvalResult eval = policy_base_->EvalPolicy(IPC_DUPLICATEHANDLEPROXY_TAG,
80 params.GetBase()); 80 params.GetBase());
81 ipc->return_info.win32_result = 81 ipc->return_info.win32_result =
82 HandlePolicy::DuplicateHandleProxyAction(eval, handle, 82 HandlePolicy::DuplicateHandleProxyAction(eval, handle.Get(),
83 target_process_id, 83 target_process_id,
84 &ipc->return_info.handle, 84 &ipc->return_info.handle,
85 desired_access, options); 85 desired_access, options);
86 return true; 86 return true;
87 } 87 }
88 88
89 } // namespace sandbox 89 } // namespace sandbox
90 90
OLDNEW
« no previous file with comments | « sandbox/win/src/handle_closer_test.cc ('k') | sandbox/win/src/handle_policy_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698