Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 606443002: Remove implicit HANDLE conversions from sandbox. (Closed)

Created:
6 years, 2 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from sandbox. BUG=416722 R=wfh@chromium.org Committed: https://crrev.com/6ab31da16265d4305670454a1fc9bfa7149dbea3 Cr-Commit-Position: refs/heads/master@{#296580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M sandbox/win/src/broker_services.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/win/src/handle_closer_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/win/src/handle_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/handle_policy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/sync_policy_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M sandbox/win/src/target_process.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/win/tests/common/controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/common/controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rvargas (doing something else)
6 years, 2 months ago (2014-09-24 22:49:33 UTC) #1
Will Harris
lgtm
6 years, 2 months ago (2014-09-24 23:08:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606443002/1
6 years, 2 months ago (2014-09-24 23:52:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 75fe80c9168dc2126d58519cb6368c93fdc7d878
6 years, 2 months ago (2014-09-25 00:02:12 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 00:03:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab31da16265d4305670454a1fc9bfa7149dbea3
Cr-Commit-Position: refs/heads/master@{#296580}

Powered by Google App Engine
This is Rietveld 408576698