src/compiler/code-generator-impl.h - Issue 606403003: Refactor BasicBlock, no inheritance from GenericNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-generator-impl.h

Issue 606403003: Refactor BasicBlock, no inheritance from GenericNode (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Attempt n+1 to address the size_t madness Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/code-generator-impl.h

diff --git a/src/compiler/code-generator-impl.h b/src/compiler/code-generator-impl.h

index a3f7e4c11d5e6972a2ac6cb3c42cd1b153c20b5d..318b7e96abb3d8362f227eecf0af92be02405f79 100644

--- a/src/compiler/code-generator-impl.h

+++ b/src/compiler/code-generator-impl.h

@@ -65,11 +65,8 @@ class InstructionOperandConverter {

}

BasicBlock* InputBlock(int index) {

- NodeId block_id = static_cast<NodeId>(InputInt32(index));

- // operand should be a block id.

- DCHECK(block_id >= 0);

- DCHECK(block_id < gen_->schedule()->BasicBlockCount());

- return gen_->schedule()->GetBlockById(block_id);

+ int block_id = InputInt32(index);

+ return gen_->schedule()->GetBlockById(BasicBlock::Id::FromInt(block_id));

}

« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/instruction.h » ('j') | no next file with comments »