Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 606403003: Refactor BasicBlock, no inheritance from GenericNode (Closed)

Created:
6 years, 2 months ago by Jarin
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactor BasicBlock to not use GenericNode. To manage BasicBlock's predecessors and successors we now use plain std::vector. The change also moves bunch of method definitions from header files to implementation files. In zlib, the change brings 3x improvement in the scheduler's memory consumption. The --turbo-stats flag says we go 169MB -> 55MB in the scheduler, 383MB -> 268MB overall. BUG=

Patch Set 1 #

Patch Set 2 : Rebase + minor fixes #

Patch Set 3 : More fixes #

Patch Set 4 : Attempt to fix the size_t madness #

Patch Set 5 : Rebase #

Patch Set 6 : Attempt n+1 to address the size_t madness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+657 lines, -477 lines) Patch
M src/basic-block-profiler.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/basic-block-profiler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/basic-block-instrumentor.cc View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-generator-impl.h View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 5 chunks +18 lines, -20 lines 0 comments Download
M src/compiler/instruction-selector.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/phi-reducer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 10 chunks +20 lines, -24 lines 0 comments Download
M src/compiler/schedule.h View 1 2 3 6 chunks +126 lines, -187 lines 0 comments Download
M src/compiler/schedule.cc View 1 2 3 4 chunks +250 lines, -15 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/compiler/scheduler.cc View 1 2 3 4 5 30 chunks +114 lines, -106 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 5 6 chunks +48 lines, -46 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-schedule.cc View 1 2 3 5 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 2 3 4 5 8 chunks +26 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please?
6 years, 2 months ago (2014-09-29 14:09:07 UTC) #2
Benedikt Meurer
LGTM, premature abstractification must die! :-)
6 years, 2 months ago (2014-09-30 05:03:55 UTC) #3
Jarin
6 years, 2 months ago (2014-10-06 15:10:02 UTC) #4
On 2014/09/30 05:03:55, Benedikt Meurer wrote:
> LGTM, premature abstractification must die! :-)

Committed as 24308.

Powered by Google App Engine
This is Rietveld 408576698