Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 606343003: Rename AndroidImage format template to match the Java class. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
Reviewers:
qinmin, boliu, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename AndroidImage format template to match the Java class. In Java the filename and classname must match. BUG=None TBR=dalecurtis@chromium.org Committed: https://crrev.com/af0ddd520ca04447fdf3b1ffeb9f11f806d14aea Cr-Commit-Position: refs/heads/master@{#297317}

Patch Set 1 #

Patch Set 2 : Fixed import in VideoCapture #

Patch Set 3 : Fix webview build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M android_webview/java_library_common.mk View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + media/base/android/java/src/org/chromium/media/AndroidImageFormat.template View 1 chunk +1 line, -1 line 0 comments Download
D media/base/android/java/src/org/chromium/media/ImageFormat.template View 1 chunk +0 lines, -12 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCapture.java View 1 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +2 lines, -3 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606343003/1
6 years, 2 months ago (2014-09-29 20:45:35 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/19954) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/20000)
6 years, 2 months ago (2014-09-29 20:58:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606343003/20001
6 years, 2 months ago (2014-09-29 22:33:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/19860)
6 years, 2 months ago (2014-09-29 23:00:52 UTC) #8
aurimas (slooooooooow)
boliu and qinmin: PTAL
6 years, 2 months ago (2014-09-29 23:44:32 UTC) #13
boliu
android_webview lgtm
6 years, 2 months ago (2014-09-29 23:48:39 UTC) #14
qinmin
lgtm
6 years, 2 months ago (2014-09-29 23:49:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606343003/40001
6 years, 2 months ago (2014-09-29 23:55:26 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f05d97f76327ef6b2d07482424a8544154ce8965
6 years, 2 months ago (2014-09-30 00:44:14 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:44:53 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/af0ddd520ca04447fdf3b1ffeb9f11f806d14aea
Cr-Commit-Position: refs/heads/master@{#297317}

Powered by Google App Engine
This is Rietveld 408576698