[CSS Grid Layout] Percentages of indefinite sizes should compute to "auto"

Source/core/rendering/RenderGrid.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 470 matching lines @@
 
     return availableLogicalSpaceIgnoringFractionTracks / accumulatedFractions;
 }
 
 const GridTrackSize& RenderGrid::gridTrackSize(GridTrackSizingDirection direction, size_t i) const
 {
     const Vector<GridTrackSize>& trackStyles = (direction == ForColumns) ? style()->gridDefinitionColumns() : style()->gridDefinitionRows();
     if (i >= trackStyles.size())
         return (direction == ForColumns) ? style()->gridAutoColumns() : style()->gridAutoRows();
 
-    return trackStyles[i];
+    const GridTrackSize& trackSize = trackStyles[i];
+    // If the logical width/height of the grid container is indefinite, percentage values are treated as <auto>.
+    if (trackSize.isPercentage()) {
+        Length logicalSize = direction == ForColumns ? style()->logicalWidth() : style()->logicalHeight();
+        if (logicalSize.isIntrinsic()) {

[ojan, 2013/12/10 22:53:26]

Should this be isInstrinsicOrAuto? Also, what if it's a percentage that resolves
to auto? Should the nested percentage compute to auto as well?

[svillar, 2013/12/16 17:46:51]

Yeah I guess auto should be considered here as indefinite size as well.

Regarding your other questions I think I don't get exactly what you mean. We're
talking about row/column sizes which are specified once per grid in
grid-template-columns/rows properties. If we insert an item sized using
percentages into the grid it should work as if it weren't inside a grid,
whatever the expected behavior is. This is just an exception to the general
rule.

+            DEFINE_STATIC_LOCAL(GridTrackSize, autoTrackSize, (Auto));

[ojan, 2013/12/10 22:53:26]

I don't expect you gain anything here by making this a static. I think you can
just return Auto directly.

[svillar, 2013/12/16 17:46:51]

Well, we need to return a reference to a GridTrackSize object with Auto sizing,
why would we want to create a new object everytime?

+            return autoTrackSize;
+        }
+    }
+
+    return trackSize;
 }
 
 size_t RenderGrid::explicitGridColumnCount() const
 {
     return style()->gridDefinitionColumns().size();
 }
 
 size_t RenderGrid::explicitGridRowCount() const
 {
     return style()->gridDefinitionRows().size();
@@ skipping 641 matching lines @@
     if (isOutOfFlowPositioned())
         return "RenderGrid (positioned)";
     if (isAnonymous())
         return "RenderGrid (generated)";
     if (isRelPositioned())
         return "RenderGrid (relative positioned)";
     return "RenderGrid";
 }
 
 } // namespace WebCore