Issue 60633007: Remove duplicated rule from core.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60633007: Remove duplicated rule from core.gyp. (Closed)

Created:
7 years, 1 month ago by lgombos

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove duplicated rule from core.gyp. This rule is covered by config.gyp. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161420

Patch Set 2 : Remove scons_line_length #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	Source/core/core.gyp	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://codereview.chromium.org/60633007/diff/1/Source/core/core.gyp File Source/core/core.gyp (right): https://codereview.chromium.org/60633007/diff/1/Source/core/core.gyp#newcode408 Source/core/core.gyp:408: 'scons_line_length' : 1, Can you delete this too? ...

7 years, 1 month ago (2013-11-06 04:10:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/60633007/60001

7 years, 1 month ago (2013-11-06 04:36:47 UTC) #3

Message was sent while issue was closed.

Change committed as 161420

Expand Messages | Collapse Messages

Issue 60633007: Remove duplicated rule from core.gyp. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove scons_line_length #

Messages