Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 60633004: Remove WebInbandTextTrack::isDefault() (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@unusedtrack
Visibility:
Public.

Description

Remove WebInbandTextTrack::isDefault() The spec only mentions the default attribute on track elements (out-of-band text tracks), in-band tracks don't have this concept. Also, because InbandTextTrack doesn't actually implement isDefault(), this is all dead code. The Chromium implementation (WebInbandTextTrackImpl) always returns false and can be removed after a Blink roll. Also remove HTMLTrackElement::isDefault() and setIsDefault(), which are dead code because [Reflect] is used in the IDL. BUG=315270 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161396

Patch Set 1 #

Patch Set 2 : remove more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/core/html/HTMLTrackElement.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/platform/graphics/media/InbandTextTrackPrivate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InbandTextTrackPrivateImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InbandTextTrackPrivateImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebInbandTextTrack.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-05 22:15:06 UTC) #1
adamk
lgtm Love these dead-code-cleanup patches!
7 years, 1 month ago (2013-11-05 22:18:20 UTC) #2
philipj_slow
On 2013/11/05 22:18:20, adamk wrote: > lgtm > > Love these dead-code-cleanup patches! Thanks! I ...
7 years, 1 month ago (2013-11-05 22:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60633004/40001
7 years, 1 month ago (2013-11-05 22:29:44 UTC) #4
abarth-chromium
public <-- LGTM
7 years, 1 month ago (2013-11-05 22:39:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60633004/40001
7 years, 1 month ago (2013-11-05 22:40:46 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 23:47:34 UTC) #7
Message was sent while issue was closed.
Change committed as 161396

Powered by Google App Engine
This is Rietveld 408576698