Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 606213002: Compile print_preview, part 6: reduce down to 48 errors (Closed)

Created:
6 years, 2 months ago by Vitaly Pavlenko
Modified:
4 years ago
CC:
chromium-reviews, arv+watch_chromium.org, Aleksey Shlyapnikov
Base URL:
https://chromium.googlesource.com/chromium/src.git@J_print_preview_5
Project:
chromium
Visibility:
Public.

Description

Compile print_preview, part 6: reduce down to 48 errors R=alekseys@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/print_preview/compiled_resources.gyp && ninja -C out/Default

Patch Set 1 #

Total comments: 2

Patch Set 2 : vitalybuka@'s review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -63 lines) Patch
M chrome/browser/resources/print_preview/cloud_print_interface.js View 15 chunks +26 lines, -18 lines 0 comments Download
M chrome/browser/resources/print_preview/data/app_state.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/data/destination.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/data/destination_store.js View 6 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/resources/print_preview/data/invitation_store.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/data/ticket_items/page_range.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/preview_generator.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_animations.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_utils.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/color_settings.js View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/layout_settings.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/media_size_settings.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/page_settings.js View 1 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Vitaly Pavlenko
6 years, 2 months ago (2014-09-27 03:48:42 UTC) #1
Vitaly Pavlenko
Hi, vitalybuka@, I'm compiling Chrome JavaScript with Closure Compiler, so I'm fixing bugs in JSDocs ...
6 years, 2 months ago (2014-09-30 00:57:00 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm https://chromiumcodereview.appspot.com/606213002/diff/1/chrome/browser/resources/print_preview/settings/page_settings.js File chrome/browser/resources/print_preview/settings/page_settings.js (right): https://chromiumcodereview.appspot.com/606213002/diff/1/chrome/browser/resources/print_preview/settings/page_settings.js#newcode112 chrome/browser/resources/print_preview/settings/page_settings.js:112: 'blur', shouldn't this be aligned like: this.tracker.add(assert(this.customInput_), 'blur', ...
6 years, 2 months ago (2014-09-30 01:21:03 UTC) #4
Vitaly Pavlenko
6 years, 2 months ago (2014-10-01 02:19:33 UTC) #5
dbeam@, please, review

https://chromiumcodereview.appspot.com/606213002/diff/1/chrome/browser/resour...
File chrome/browser/resources/print_preview/settings/page_settings.js (right):

https://chromiumcodereview.appspot.com/606213002/diff/1/chrome/browser/resour...
chrome/browser/resources/print_preview/settings/page_settings.js:112: 'blur',
On 2014/09/30 01:21:03, Vitaly Buka wrote:
> shouldn't this be aligned like:
> 
> this.tracker.add(assert(this.customInput_), 'blur',
>                  this.onCustomInputBlur_.bind(this));

Done.

Powered by Google App Engine
This is Rietveld 408576698