Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8423)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Colon on next line. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index f60165313ce646f285a53d350bd21bd34cf4fe3e..c4829cbf97c7eea99182b0733a9af1919482fed2 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -336,7 +336,7 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
// TODO(gcasto): Validate data in PasswordForm.
// Not yet implemented on other platforms.
-#if defined(USE_AURA) || defined(OS_MACOSX)
+#if defined(USE_AURA) || defined(OS_MACOSX) || defined(OS_ANDROID)
Garrett Casto 2014/10/27 22:48:58 You should be able to remove these macros now. Lin
please use gerrit instead 2014/10/27 22:57:05 Done.
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
@@ -350,7 +350,7 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(true /* display_password */);
-#endif // defined(USE_AURA) || defined(OS_MACOSX)
+#endif // defined(USE_AURA) || defined(OS_MACOSX) || defined(OS_ANDROID)
}
void ChromePasswordManagerClient::ShowPasswordEditingPopup(
@@ -358,7 +358,7 @@ void ChromePasswordManagerClient::ShowPasswordEditingPopup(
const autofill::PasswordForm& form) {
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
// Not yet implemented on other platforms.
-#if defined(USE_AURA) || defined(OS_MACOSX)
+#if defined(USE_AURA) || defined(OS_MACOSX) || defined(OS_ANDROID)
popup_controller_ =
autofill::PasswordGenerationPopupControllerImpl::GetOrCreate(
popup_controller_,
@@ -370,7 +370,7 @@ void ChromePasswordManagerClient::ShowPasswordEditingPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(false /* display_password */);
-#endif // defined(USE_AURA) || defined(OS_MACOSX)
+#endif // defined(USE_AURA) || defined(OS_MACOSX) || defined(OS_ANDROID)
}
void ChromePasswordManagerClient::NotifyRendererOfLoggingAvailability() {

Powered by Google App Engine
This is Rietveld 408576698