Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set the width of the popup correctly. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
new file mode 100644
index 0000000000000000000000000000000000000000..a6b6126e0d492f11802a97ef82bf06ceb1579f25
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
@@ -0,0 +1,152 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.autofill;
+
+import android.content.Context;
+import android.os.Handler;
+import android.view.View;
+import android.widget.AdapterView;
+import android.widget.PopupWindow;
+
+import org.chromium.base.CalledByNative;
+import org.chromium.base.JNINamespace;
+import org.chromium.ui.DropdownPopupWindow;
+import org.chromium.ui.base.ViewAndroid;
+import org.chromium.ui.base.ViewAndroidDelegate;
+import org.chromium.ui.base.WindowAndroid;
+
+/**
+ * JNI call glue for password generation between native and Java objects.
+ */
+@JNINamespace("autofill")
+public class PasswordGenerationPopupBridge implements AdapterView.OnItemClickListener,
+ PopupWindow.OnDismissListener, PasswordGenerationAdapter.Delegate {
+ private final long mNativePasswordGenerationPopupViewAndroid;
+ private final Context mContext;
+ private final DropdownPopupWindow mPopup;
+
+ /**
+ * A convenience method for the constructor to be invoked from the native counterpart.
+ * @param nativePopup The pointer to the native counterpart.
+ * @param windowAndroid The browser window.
+ * @param containerViewDelegate Interface to acquire and release anchors.
+ */
+ @CalledByNative
+ private static PasswordGenerationPopupBridge create(long nativePopup,
+ WindowAndroid windowAndroid, ViewAndroid viewAndroid) {
+ return new PasswordGenerationPopupBridge(nativePopup, windowAndroid,
+ viewAndroid.getViewAndroidDelegate());
+ }
+
+ /**
+ * Builds the bridge between native and Java objects.
+ * @param nativePopup The pointer to the native counterpart.
+ * @param windowAndroid The browser window.
+ * @param containerViewDelegate Interface to acquire and release anchors.
+ */
+ public PasswordGenerationPopupBridge(long nativePopup, WindowAndroid windowAndroid,
+ ViewAndroidDelegate containerViewDelegate) {
+ mNativePasswordGenerationPopupViewAndroid = nativePopup;
+ mContext = windowAndroid.getActivity().get();
+ if (mContext == null) {
+ mPopup = null;
+ new Handler().post(new Runnable() {
aurimas (slooooooooow) 2014/10/23 00:57:01 Can you explain why we need this runnable? In what
+ @Override
+ public void run() {
+ onDismiss();
+ }
+ });
+ } else {
+ mPopup = new DropdownPopupWindow(mContext, containerViewDelegate);
+ mPopup.setOnItemClickListener(this);
+ mPopup.setOnDismissListener(this);
+ }
+ }
+
+ /**
+ * Handles clicks on popup list elements. Only suggestion element is enabled. Clicking on the
+ * suggestion element notifies the native counterpart that the suggested password was selected.
+ * @param parent The parent view where the click happened.
+ * @param view The view that was provided by the adapter that was clicked.
+ * @param position The position of the view in the adapter.
+ * @param id The row id of the clicked element.
+ */
+ @Override
+ public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
+ nativePasswordSelected(mNativePasswordGenerationPopupViewAndroid);
+ }
+
+ private native void nativePasswordSelected(long nativePasswordGenerationPopupViewAndroid);
+
+ /**
+ * Handles dismissing the popup window. The native counterpart is notified to destroy the
+ * controller.
+ */
+ @Override
+ public void onDismiss() {
+ nativeDismissed(mNativePasswordGenerationPopupViewAndroid);
+ }
+
+ private native void nativeDismissed(long nativePasswordGenerationPopupViewAndroid);
+
+ /**
+ * Sets the location and size of the popup anchor (password input field).
+ * @param x X coordinate.
+ * @param y Y coordinate.
+ * @param width The width of the anchor.
+ * @param height The height of the anchor.
+ */
+ @CalledByNative
+ private void setAnchorRect(float x, float y, float width, float height) {
+ if (mPopup != null) mPopup.setAnchorRect(x, y, width, height);
+ }
+
+ /**
+ * Shows a password generation popup with specified data. Should be called after
+ * setAnchorRect().
+ * @param isRtl True if the popup should be RTL.
+ * @param passwordDisplayed Whether the generated password should be displayed.
+ * @param password The auto-generated password to suggest.
+ * @param suggestionTitle The translated title of the suggestion part of the popup.
+ * @param explanationText The translated text that explains the popup.
+ * @param explanationTextLinkRangeStart The start of the range in the explanation text that
+ * should be a link to the saved passwords.
+ * @param explanationTextLinkRangeEnd The end of the range in the explanation text that should
+ * be a link to the saved passwords.
+ */
+ @CalledByNative
+ private void show(boolean isRtl, boolean passwordDisplayed, String password,
+ String suggestionTitle, String explanationText, int explanationTextLinkRangeStart,
+ int explanationTextLinkRangeEnd) {
+ if (mPopup != null) {
+ PasswordGenerationAdapter adapter = new PasswordGenerationAdapter(mContext, this,
+ passwordDisplayed, password, suggestionTitle, explanationText,
+ explanationTextLinkRangeStart, explanationTextLinkRangeEnd,
+ mPopup.getAnchorWidth());
+ mPopup.setAdapter(adapter);
+ mPopup.setRtl(isRtl);
+ mPopup.show();
+ }
+ }
+
+ /**
+ * Called from adapter when the "saved passwords" link is clicked.
+ */
+ @Override
+ public void onSavedPasswordsLinkClicked() {
+ nativeSavedPasswordsLinkClicked(mNativePasswordGenerationPopupViewAndroid);
+ }
+
+ private native void nativeSavedPasswordsLinkClicked(
+ long nativePasswordGenerationPopupViewAndroid);
+
+ /**
+ * Hides the password generation popup.
+ */
+ @CalledByNative
+ private void hide() {
+ if (mPopup != null) mPopup.dismiss();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698