chrome/android/java/res/layout/password_generation_popup_explanation.xml - Issue 606153002: [android] Password generation UI for android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/password_generation_popup_explanation.xml

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ready to reivew. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/res/layout/password_generation_popup_suggestion.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="wrap_content"

	10 android:layout_height="wrap_content">

	11

	12 <TextView android:id="@+id/password_generation_explanation"

	13 android:layout_width="wrap_content"

	14 android:layout_height="wrap_content"

	15 android:paddingTop="@dimen/password_generation_text_vertical_margin"

	16 android:paddingBottom="@dimen/password_generation_text_vertical_margin"

	17 android:paddingStart="@dimen/password_generation_horizontal_margin"

	18 android:paddingEnd="@dimen/password_generation_horizontal_margin"

	19 android:includeFontPadding="false"
	aurimas (slooooooooow) 2014/10/24 23:35:01 Why do we need to set this to false? I have seen v Why do we need to set this to false? I have seen very few places that use this attribute. please use gerrit instead 2014/10/25 00:18:12 Settings this to false removes the extra padding f Show quoted text On 2014/10/24 23:35:01, aurimas wrote: > Why do we need to set this to false? I have seen very few places that use this > attribute. Settings this to false removes the extra padding for accents that go beyond the normal ascent and descent of the font. I've added this to make password generation dropdown to look consistent with the rest of the dropdowns in Chrome. See https://code.google.com/p/chromium/codesearch#chromium/src/ui/android/java/re....
	20 android:textColor="@color/password_generation_explanation_text_color"

	21 android:textSize="@dimen/password_generation_text_size"/>

	22

	23 </RelativeLayout>

OLD	NEW