Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 606143003: Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Convert scoped_ptr<...>() to nullptr in mojo/embedder. R=jamesr@chromium.org Committed: https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71 Cr-Commit-Position: refs/heads/master@{#297093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M mojo/embedder/simple_platform_shared_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/embedder/simple_platform_shared_buffer_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-27 01:08:40 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-27 01:09:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606143003/1
6 years, 2 months ago (2014-09-27 01:28:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as f7009cc58669594c34c1ad5be44fb028ceb9d4cd
6 years, 2 months ago (2014-09-27 02:05:19 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b198fa11edbe68701e12c27d5f4981398f5ca71 Cr-Commit-Position: refs/heads/master@{#297093}
6 years, 2 months ago (2014-09-27 02:06:04 UTC) #6
dcheng
6 years, 2 months ago (2014-09-27 07:42:16 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/593313006/ by dcheng@chromium.org.

The reason for reverting is: scoped_ptr nullptr support was reverted..

Powered by Google App Engine
This is Rietveld 408576698