Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: gin/per_context_data.h

Issue 60613003: Add a dependency from Gin to base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/per_context_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/per_context_data.h
diff --git a/gin/per_context_data.h b/gin/per_context_data.h
index 123db59ddf7e7e289332e616effc7116fcfa06c5..0f104852a9613337a0033714afae2a677de2900d 100644
--- a/gin/per_context_data.h
+++ b/gin/per_context_data.h
@@ -5,8 +5,9 @@
#ifndef GIN_PER_CONTEXT_DATA_H_
#define GIN_PER_CONTEXT_DATA_H_
-#include <vector>
#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/scoped_vector.h"
#include "v8/include/v8.h"
namespace gin {
@@ -31,13 +32,11 @@ class PerContextData {
static PerContextData* From(v8::Handle<v8::Context>);
void Detach(v8::Handle<v8::Context> context);
- // Takes ownership of the supplement.
- void AddSupplement(ContextSupplement* supplement);
+ void AddSupplement(scoped_ptr<ContextSupplement> supplement);
private:
- typedef std::vector<ContextSupplement*> SuplementVector;
+ typedef ScopedVector<ContextSupplement> SuplementVector;
- // Owning reference.
SuplementVector supplements_;
DISALLOW_COPY_AND_ASSIGN(PerContextData);
« no previous file with comments | « gin/modules/module_registry.cc ('k') | gin/per_context_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698