Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: gin/modules/module_registry.h

Issue 60613003: Add a dependency from Gin to base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/initialize.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index 7cff355963725107010cdf99994ed8e85ec32bd6..96ea1496f2396cf7505f643e999e5fdbd0cbc143 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -27,6 +27,8 @@ struct PendingModule;
//
class ModuleRegistry : public ContextSupplement {
public:
+ virtual ~ModuleRegistry();
+
static ModuleRegistry* From(v8::Handle<v8::Context> context);
static void RegisterGlobals(v8::Isolate* isolate,
@@ -45,7 +47,6 @@ class ModuleRegistry : public ContextSupplement {
typedef std::list<PendingModule*> PendingModuleList; // Owning reference.
explicit ModuleRegistry(v8::Isolate* isolate);
- virtual ~ModuleRegistry();
// From ContextSupplement:
virtual void Detach(v8::Handle<v8::Context> context) OVERRIDE;
« no previous file with comments | « gin/initialize.cc ('k') | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698