Issue 60613003: Add a dependency from Gin to base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60613003: Add a dependency from Gin to base (Closed)

Created:
7 years, 1 month ago by abarth-chromium

Modified:
7 years, 1 month ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a dependency from Gin to base This CL adds a direct dependency from Gin to base, making it easier to write sane code. The main clients we expect for this code will already link against base, so this isn't much of a cost. R=aa@chromium.org BUG=317398

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -55 lines)			Patch
M	gin/DEPS	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	gin/arguments.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	gin/array_buffer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/array_buffer.cc	View	4 chunks	+7 lines, -19 lines	0 comments	Download
M	gin/context_holder.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	gin/context_holder.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	gin/gin.gyp	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	gin/initialize.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/module_registry.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	gin/modules/module_registry.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	gin/per_context_data.h	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	gin/per_context_data.cc	View	4 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

7 years, 1 month ago (2013-11-18 15:37:15 UTC) #2

Message was sent while issue was closed.

I've rolled this CL into https://codereview.chromium.org/74753002/

Expand Messages | Collapse Messages