Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 606123002: gn format: make sure there's a blank line before comments, except at block start (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-format-crash-no-block
Project:
chromium
Visibility:
Public.

Description

gn format: make sure there's a blank line before comments, except at block start With this, gn format //BUILD.gn results in no changes, other than to make 'deps += [ "a" ]' turn into one line instead of multiline. (Child of https://codereview.chromium.org/608593006/) R=brettw@chromium.org BUG=348474 Committed: https://crrev.com/0abd867e991007102a89979f8316267fb2209cbb Cr-Commit-Position: refs/heads/master@{#297231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
M tools/gn/command_format.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M tools/gn/command_format_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/format_test_data/019.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/gn/format_test_data/019.golden View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 2 months ago (2014-09-26 21:28:34 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-09-29 16:49:42 UTC) #2
scottmg
Committed patchset #1 (id:1) manually as 0abd867e991007102a89979f8316267fb2209cbb (presubmit successful).
6 years, 2 months ago (2014-09-29 19:30:57 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:30:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0abd867e991007102a89979f8316267fb2209cbb
Cr-Commit-Position: refs/heads/master@{#297231}

Powered by Google App Engine
This is Rietveld 408576698