Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 606093002: android scroller: Stop fling earlier. (Closed)

Created:
6 years, 2 months ago by sadrul
Modified:
6 years, 2 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android scroller: Stop fling earlier. If the fling update is close to the final state, then stop the fling. The threshold for this used to be 1e-5f, but change it to 1e-1f, since there won't be any visual changes for subsequent fling-update steps. BUG=none R=jdduke@chromium.org Committed: https://crrev.com/a12fd96dc1bfcf8bc6ca88d40515d7a58da2e16a Cr-Commit-Position: refs/heads/master@{#297198}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M ui/gfx/android/scroller.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M ui/gfx/android/scroller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sadrul
6 years, 2 months ago (2014-09-26 22:14:19 UTC) #2
jdduke (slow)
lgtm https://codereview.chromium.org/606093002/diff/20001/ui/gfx/android/scroller.cc File ui/gfx/android/scroller.cc (right): https://codereview.chromium.org/606093002/diff/20001/ui/gfx/android/scroller.cc#newcode329 ui/gfx/android/scroller.cc:329: const float kThresholdForFlingEnd = 0.1; Nit: Might as ...
6 years, 2 months ago (2014-09-26 22:19:53 UTC) #3
sadrul
https://codereview.chromium.org/606093002/diff/20001/ui/gfx/android/scroller.cc File ui/gfx/android/scroller.cc (right): https://codereview.chromium.org/606093002/diff/20001/ui/gfx/android/scroller.cc#newcode329 ui/gfx/android/scroller.cc:329: const float kThresholdForFlingEnd = 0.1; On 2014/09/26 22:19:53, jdduke ...
6 years, 2 months ago (2014-09-29 17:23:56 UTC) #4
sadrul
Committed patchset #3 (id:40001) manually as a12fd96 (presubmit successful).
6 years, 2 months ago (2014-09-29 17:26:12 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 17:26:14 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a12fd96dc1bfcf8bc6ca88d40515d7a58da2e16a
Cr-Commit-Position: refs/heads/master@{#297198}

Powered by Google App Engine
This is Rietveld 408576698