Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: chrome/browser/resources/gaia_auth/background.js

Issue 606083002: patch from issue 473153002 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix saml Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gaia_auth/background.js
diff --git a/chrome/browser/resources/gaia_auth/background.js b/chrome/browser/resources/gaia_auth/background.js
index ffe0b0785871f96bee7a2357e42d142266732860..f8be49c3d751b9776b95b4504d245510577ae748 100644
--- a/chrome/browser/resources/gaia_auth/background.js
+++ b/chrome/browser/resources/gaia_auth/background.js
@@ -119,6 +119,10 @@ BackgroundBridge.prototype = {
// 'google-accounts-signin'.
email_: null,
+ // Gaia Id of the newly authenticated user based on the gaia response
+ // header 'google-accounts-signin'.
+ gaiaId_: null,
+
// Session index of the newly authenticated user based on the gaia response
// header 'google-accounts-signin'.
sessionIndex_: null,
@@ -204,7 +208,7 @@ BackgroundBridge.prototype = {
onCompleted: function(details) {
// Only monitors requests in the gaia frame whose parent frame ID must be
// positive.
- if (!this.isDesktopFlow_ || details.parentFrameId <= 0)
+ if (details.parentFrameId <= 0)
return;
if (details.url.lastIndexOf(backgroundBridgeManager.CONTINUE_URL_BASE, 0) ==
@@ -218,6 +222,7 @@ BackgroundBridge.prototype = {
var msg = {
'name': 'completeLogin',
'email': this.email_,
+ 'gaiaId': this.gaiaId_,
'password': passwords[0],
'sessionIndex': this.sessionIndex_,
'skipForNow': skipForNow
@@ -262,11 +267,8 @@ BackgroundBridge.prototype = {
onHeadersReceived: function(details) {
var headers = details.responseHeaders;
- if (this.isDesktopFlow_ &&
- this.gaiaUrl_ &&
- details.url.lastIndexOf(this.gaiaUrl_) == 0) {
- // TODO(xiyuan, guohui): CrOS should reuse the logic below for reading the
- // email for SAML users and cut off the /ListAccount call.
+ if (!this.isDesktopFlow_ ||
+ (this.gaiaUrl_ && details.url.lastIndexOf(this.gaiaUrl_) == 0)) {
for (var i = 0; headers && i < headers.length; ++i) {
if (headers[i].name.toLowerCase() == 'google-accounts-signin') {
var headerValues = headers[i].value.toLowerCase().split(',');
@@ -277,6 +279,7 @@ BackgroundBridge.prototype = {
});
// Remove "" around.
this.email_ = signinDetails['email'].slice(1, -1);
+ this.gaiaId_ = signinDetails['obfuscatedid'].slice(1, -1);
this.sessionIndex_ = signinDetails['sessionindex'];
break;
}
« no previous file with comments | « chrome/browser/resources/component_extension_resources.grd ('k') | chrome/browser/resources/gaia_auth/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698