Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 606023003: Don't bubble scrolls across boundary when scrolling to anchor (Closed)

Created:
6 years, 2 months ago by Ian Vollick
Modified:
6 years, 2 months ago
Reviewers:
esprehn
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Don't bubble scrolls across boundary when scrolling to anchor Takes the same approach as FrameLoader to ensure that we don't bubble scrolls incorrectly. BUG=415141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182954

Patch Set 1 #

Patch Set 2 : Now with test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A LayoutTests/http/tests/navigation/anchor-frames-shifting-focus.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/anchor-frames-shifting-focus-expected.html View 1 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/navigation/resources/focus-shifting-frame-with-anchor.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Ian Vollick
This is how I feel about this patch: http://i.imgur.com/DdnLHhA.gif
6 years, 2 months ago (2014-09-26 20:59:16 UTC) #2
Ian Vollick
On 2014/09/26 20:59:16, vollick wrote: > This is how I feel about this patch: http://i.imgur.com/DdnLHhA.gif ...
6 years, 2 months ago (2014-09-30 10:48:22 UTC) #3
Ian Vollick
On 2014/09/30 10:48:22, vollick wrote: > On 2014/09/26 20:59:16, vollick wrote: > > This is ...
6 years, 2 months ago (2014-09-30 10:49:19 UTC) #4
esprehn
lgtm
6 years, 2 months ago (2014-09-30 15:14:17 UTC) #5
Ian Vollick
lgtm
6 years, 2 months ago (2014-09-30 15:15:33 UTC) #6
Ian Vollick
lgtm
6 years, 2 months ago (2014-09-30 17:28:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606023003/20001
6 years, 2 months ago (2014-09-30 17:29:37 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:13:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182954

Powered by Google App Engine
This is Rietveld 408576698