Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 606013002: Install function tables for the code range on Win64 (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Install function tables for the code range on Win64 The function table needs to live in the code range. Currently, I'm just taking an entire memory chunk out of the code range and put the few bytes of the structure in there. Can probably be optimized. Note that the resulting crashdump contains the stack, but can't be automatically symbolized, because, not ABI compliant. BUG=v8:3597 R=danno@chromium.org LOG=y

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
M include/v8.h View 3 chunks +23 lines, -0 lines 3 comments Download
M src/api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +64 lines, -0 lines 7 comments Download

Messages

Total messages: 6 (1 generated)
cpu_(ooo_6.6-7.5)
mostly questions. https://codereview.chromium.org/606013002/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/606013002/diff/40001/include/v8.h#newcode4345 include/v8.h:4345: #endif __cdecl ? are you sure? https://codereview.chromium.org/606013002/diff/40001/src/x64/codegen-x64.cc ...
6 years, 2 months ago (2014-09-26 17:03:51 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/606013002/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/606013002/diff/40001/include/v8.h#newcode4345 include/v8.h:4345: #endif On 2014/09/26 19:03:51, cpu wrote: > __cdecl ? ...
6 years, 2 months ago (2014-09-26 17:25:31 UTC) #3
jochen (gone - plz use gerrit)
__ is just defined as masm-> (see a few lines above) the general idea is ...
6 years, 2 months ago (2014-09-26 17:38:18 UTC) #4
cpu_(ooo_6.6-7.5)
I am still thinking that we have __cdecl vs __stdcall issue, we are called, very ...
6 years, 2 months ago (2014-09-26 20:35:31 UTC) #5
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-09-30 07:34:00 UTC) #6
moved this to chromium here: https://codereview.chromium.org/619543002

Powered by Google App Engine
This is Rietveld 408576698