Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 606012: Get rid of use of deprecated members in ImeLookupTable. (Closed)

Created:
10 years, 10 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, mazda
Visibility:
Public.

Description

Get rid of use of deprecated members in ImeLookupTable. Namely: - current_page_index - cursor_row_index - num_candidates_in_current_page - num_pages (not used in candidate_window.cc, but this will also be deleted in libcros) These members will be deleted from libcros in a separate CL. TEST=manually BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39044

Patch Set 1 #

Patch Set 2 : comments fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M chrome/browser/chromeos/text_input/candidate_window.cc View 1 6 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
10 years, 10 months ago (2010-02-12 07:18:27 UTC) #1
Yusuke Sato
10 years, 10 months ago (2010-02-15 02:24:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698