Fix PrerenderFromOmnibox field trial by removing the hard-coded percentages,

Fix PrerenderFromOmnibox field trial by removing the hard-coded percentages,
and having it rely entirely on Finch.
BUG=417851
R=rkaplow, cbentzel

Committed: https://crrev.com/d0fa7a780e8d12567d331c0e232c50a14e2c8574
Cr-Commit-Position: refs/heads/master@{#297157}

[tburkard, 2014-09-26 14:47:57]

Per our discussion in email.

Robert, if you could please verify that I am querying the Finch trial correctly.

Thanks.

[rkaplow, 2014-09-26 14:57:56]

lgtm

[cbentzel, 2014-09-29 11:19:17]

LGTM

https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_field_trial.cc:268: return
(FieldTrialList::FindFullName("PrerenderFromOmnibox") !=
Do you anticipate ever having multiple Disabled groups? Should this just check
if name begins with OmniboxPrerenderDisabled?

[tburkard, 2014-09-29 11:22:11]

https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_field_trial.cc (right):

https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_field_trial.cc:268: return
(FieldTrialList::FindFullName("PrerenderFromOmnibox") !=
On 2014/09/29 11:19:17, cbentzel wrote:
> Do you anticipate ever having multiple Disabled groups? Should this just check
> if name begins with OmniboxPrerenderDisabled?

I think we don't have a need for this at this point. All the other Finch trials
we have for prerender don't have this, so would make more sense to make such a
change in a way to cover all finch trials the same way. But like I said, I don't
see any specific need for this at this point.

Thanks.

[tburkard, 2014-09-29 11:23:32]

On 2014/09/29 11:22:11, tburkard wrote:
>
https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
> File chrome/browser/prerender/prerender_field_trial.cc (right):
> 
>
https://codereview.chromium.org/606003003/diff/1/chrome/browser/prerender/pre...
> chrome/browser/prerender/prerender_field_trial.cc:268: return
> (FieldTrialList::FindFullName("PrerenderFromOmnibox") !=
> On 2014/09/29 11:19:17, cbentzel wrote:
> > Do you anticipate ever having multiple Disabled groups? Should this just
check
> > if name begins with OmniboxPrerenderDisabled?
> 
> I think we don't have a need for this at this point. All the other Finch
trials
> we have for prerender don't have this, so would make more sense to make such a
> change in a way to cover all finch trials the same way. But like I said, I
don't
> see any specific need for this at this point.
> 
> Thanks.

In fact, would be best to make this a Finch/field trial framework option, that
you can split trial groups into separate buckets and get reports on a per bucket
basis, without each piece of code checking the trial group having to check a
string prefix rather than a comparison.

[tburkard, 2014-09-29 11:23:55]

The CQ bit was checked by tburkard@chromium.org

[commit-bot: I haz the power, 2014-09-29 11:24:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606003003/1

[commit-bot: I haz the power, 2014-09-29 11:36:28]

Committed patchset #1 (id:1) as fa743abd32bfcddbc935fda24973746abc04b723

[commit-bot: I haz the power, 2014-09-29 11:37:02]

Patchset 1 (id:??) landed as
https://crrev.com/d0fa7a780e8d12567d331c0e232c50a14e2c8574
Cr-Commit-Position: refs/heads/master@{#297157}