elf/nacl_fixup_ldso.py - Issue 605943003: Whitespace change to bump glibc rev for nacl-gcc va_list ABI change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: elf/nacl_fixup_ldso.py

Issue 605943003: Whitespace change to bump glibc rev for nacl-gcc va_list ABI change. (Closed) Base URL: http://git.chromium.org/native_client/nacl-glibc.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: elf/nacl_fixup_ldso.py

diff --git a/elf/nacl_fixup_ldso.py b/elf/nacl_fixup_ldso.py

index a5eb1f9eea1e32680b10909f76a2c97bb4ab61b1..7547597bc8221f49e60b7fcd27f260af47d2aabd 100644

--- a/elf/nacl_fixup_ldso.py

+++ b/elf/nacl_fixup_ldso.py

@@ -27,7 +27,7 @@ def main(args):

raise Exception("Usage: fixup <filename>")

filename = args[0]

fh = open(filename, "r+")

Mark Seaborn 2014/10/07 21:58:29 Nit: is there still trailing whitespace here? You

jvoung (off chromium) 2014/10/07 23:04:21 Done

def check(ty, offset, expected):

fh.seek(offset)

data = fh.read(struct.calcsize(ty))

« no previous file with comments | « no previous file | no next file » | no next file with comments »