Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 605943003: Whitespace change to bump glibc rev for nacl-gcc va_list ABI change. (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : one more space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M elf/nacl_fixup_ldso.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-10-07 16:37:32 UTC) #2
Mark Seaborn
> http://chromegw.corp.google.com/i/tryserver.nacl/builders/nacl-toolchain-precise64-glibc/builds/85 > http://chromegw.corp.google.com/i/tryserver.nacl/builders/nacl-toolchain-win7-glibc/builds/279 Can you use public URLs instead, or not mention those URLs? ...
6 years, 2 months ago (2014-10-07 21:58:30 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/605943003/diff/1/elf/nacl_fixup_ldso.py File elf/nacl_fixup_ldso.py (right): https://codereview.chromium.org/605943003/diff/1/elf/nacl_fixup_ldso.py#newcode30 elf/nacl_fixup_ldso.py:30: On 2014/10/07 21:58:29, Mark Seaborn wrote: > Nit: is ...
6 years, 2 months ago (2014-10-07 23:04:21 UTC) #4
jvoung (off chromium)
6 years, 2 months ago (2014-10-08 00:01:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f78e18e4ad2194ee8ec23e90c069ccfffae97e0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698