Issue 605903002: Do not timeout QUIC connections when settings the timeouts from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 605903002: Do not timeout QUIC connections when settings the timeouts from (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Factor_out_QUIC_timeout_alarm_75915264

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not timeout QUIC connections when settings the timeouts from InitializeSession(). Protected by FLAG_quic_timeouts_only_from_alarms Removes FLAG_quic_timeouts_require_activity which was somewhat broken. Merge internal change: 75927669 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -31 lines)			Patch
M	net/quic/quic_connection.cc	View	4 chunks	+12 lines, -16 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/605903002/diff/1/net/quic/quic_flags.cc File net/quic/quic_flags.cc (right): https://codereview.chromium.org/605903002/diff/1/net/quic/quic_flags.cc#newcode44 net/quic/quic_flags.cc:44: bool FLAGS_quic_timeouts_only_from_alarms = false; I think we can ...

6 years, 2 months ago (2014-09-26 03:21:31 UTC) #2

ramant (doing other things)

6 years, 2 months ago (2014-09-26 16:48:35 UTC) #3

https://codereview.chromium.org/605903002/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/605903002/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:44: bool FLAGS_quic_timeouts_only_from_alarms = false;
On 2014/09/26 03:21:31, Ryan Hamilton wrote:
> I think we can set this to true, if you wish. Or feel free to do this later.

Changed it in the "Land Recent QUIC Changes."

   https://codereview.chromium.org/605733006/
Done.

Expand Messages | Collapse Messages