Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 605873002: Fix RNDIS: start host iface properly, update device default gateway. (Closed)

Created:
6 years, 2 months ago by slamm
Modified:
6 years, 2 months ago
Reviewers:
wuhu, slamm_google, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, chrishenry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix RNDIS: override default gateway and leave network manager running. BUG=417894, 417889 Committed: https://crrev.com/f2d01c1247ccb364793dc5a807ac8af0c5973ec7 Cr-Commit-Position: refs/heads/master@{#297553}

Patch Set 1 #

Patch Set 2 : Reorder methods. #

Patch Set 3 : Override default gateway and leave network manager running. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 1 2 5 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
slamm
RNDIS is broken on latest Google-issued Ubuntu hosts. My change makes default gateway override happen ...
6 years, 2 months ago (2014-09-26 00:25:26 UTC) #2
slamm
Ping, tonyg.
6 years, 2 months ago (2014-09-30 22:13:33 UTC) #3
tonyg
lgtm
6 years, 2 months ago (2014-09-30 22:15:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605873002/40001
6 years, 2 months ago (2014-09-30 22:24:21 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4491b0053985ab5000303a6f720beed559dd39bc
6 years, 2 months ago (2014-10-01 00:05:28 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 00:06:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f2d01c1247ccb364793dc5a807ac8af0c5973ec7
Cr-Commit-Position: refs/heads/master@{#297553}

Powered by Google App Engine
This is Rietveld 408576698