Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 605863002: [chromedriver] Allow excludesSwitches on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index 19ccd76bd7a59364b111630e8eec1c4a9925956b..9e403af735dd5cf74416fec697a716c68dd03fc9 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -389,6 +389,7 @@ Status ParseChromeOptions(
parser_map["androidUseRunningApp"] =
base::Bind(&ParseBoolean, &capabilities->android_use_running_app);
parser_map["args"] = base::Bind(&ParseSwitches);
+ parser_map["excludeSwitches"] = base::Bind(&ParseExcludeSwitches);
parser_map["loadAsync"] = base::Bind(&IgnoreDeprecatedOption, "loadAsync");
} else if (is_remote) {
parser_map["debuggerAddress"] = base::Bind(&ParseUseRemoteBrowser);
@@ -396,7 +397,6 @@ Status ParseChromeOptions(
parser_map["args"] = base::Bind(&ParseSwitches);
parser_map["binary"] = base::Bind(&ParseFilePath, &capabilities->binary);
parser_map["detach"] = base::Bind(&ParseBoolean, &capabilities->detach);
- parser_map["mobileEmulation"] = base::Bind(&ParseMobileEmulation);
parser_map["excludeSwitches"] = base::Bind(&ParseExcludeSwitches);
parser_map["extensions"] = base::Bind(&ParseExtensions);
parser_map["forceDevToolsScreenshot"] = base::Bind(
@@ -407,6 +407,7 @@ Status ParseChromeOptions(
parser_map["logPath"] = base::Bind(&ParseLogPath);
parser_map["minidumpPath"] =
base::Bind(&ParseString, &capabilities->minidump_path);
+ parser_map["mobileEmulation"] = base::Bind(&ParseMobileEmulation);
parser_map["prefs"] = base::Bind(&ParseDict, &capabilities->prefs);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698