Show errors reported for invalid setBreakpoint calls.

editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/ServerBreakpointManager.java

 /*
  * Copyright (c) 2013, the Dart project authors.
  * 
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  * 
  * http://www.eclipse.org/legal/epl-v10.html
  * 
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
 
 package com.google.dart.tools.debug.core.server;
 
 import com.google.dart.tools.core.DartCore;
+import com.google.dart.tools.core.internal.util.ResourceUtil;
 import com.google.dart.tools.debug.core.DartDebugCorePlugin;
 import com.google.dart.tools.debug.core.breakpoints.DartBreakpoint;
 
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IMarkerDelta;
 import org.eclipse.debug.core.DebugPlugin;
 import org.eclipse.debug.core.IBreakpointListener;
 import org.eclipse.debug.core.model.IBreakpoint;
 
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.concurrent.atomic.AtomicInteger;
 
 // TODO: handle removing deleted breakpoints
 
 /**
  * This breakpoint manager serves to off-load some of the breakpoint logic from ServerDebugTarget.
  */
 class ServerBreakpointManager implements IBreakpointListener {
+  private class SetBreakpointHelper {
+    final int NUM_URLS = 2;
+
+    final VmIsolate isolate;
+    final DartBreakpoint breakpoint;
+    final int line;
+    final AtomicInteger numErrors = new AtomicInteger();
+
+    public SetBreakpointHelper(VmIsolate isolate, DartBreakpoint breakpoint, int line) {
+      this.isolate = isolate;
+      this.breakpoint = breakpoint;
+      this.line = line;
+    }
+
+    void setBreakpoint(String url) throws IOException {
+      // fail if no URL
+      if (url == null) {
+        if (numErrors.incrementAndGet() == NUM_URLS) {
+          target.writeToStdout("No valid URL for: " + breakpoint);
+        }
+        return;
+      }
+      // try to set
+      getConnection().setBreakpoint(isolate, url, line, new VmCallback<VmBreakpoint>() {
+        @Override
+        public void handleResult(VmResult<VmBreakpoint> result) {
+          if (result.isError()) {
+            if (numErrors.incrementAndGet() == NUM_URLS) {
+              String error = result.getError();
+              target.writeToStdout(error);
+            }
+          } else {
+            addCreatedBreakpoint(breakpoint, result.getResult());
+          }
+        }
+      });
+    }
+  }
+
   private ServerDebugTarget target;
 
   private VmIsolate mainIsolate;
 
   private List<IBreakpoint> ignoredBreakpoints = new ArrayList<IBreakpoint>();
 
   Map<IBreakpoint, List<VmBreakpoint>> createdBreakpoints = new HashMap<IBreakpoint, List<VmBreakpoint>>();
 
   List<VmIsolate> liveIsolates = new ArrayList<VmIsolate>();
 
@@ skipping 169 matching lines @@
     }
 
     if (!enabled) {
       return;
     }
 
     try {
       VmInterruptResult interruptResult = pause ? getConnection().interruptConditionally(isolate)
           : VmInterruptResult.createNoopResult(getConnection());
 
-      for (final DartBreakpoint breakpoint : breakpoints) {
+      for (DartBreakpoint breakpoint : breakpoints) {
         if (breakpoint.isBreakpointEnabled()) {
-          IFile file = breakpoint.getFile();
-          String url = null;
-
-          if (file != null) {
-            url = getAbsoluteUrlForResource(file);
+          int line = breakpoint.getLine();
+          SetBreakpointHelper helper = new SetBreakpointHelper(isolate, breakpoint, line);
+          // file path
+          String filePath = breakpoint.getActualFilePath();
+          if (filePath == null) {
+            continue;
           }
-
-          int line = breakpoint.getLine();
-
-          if (url != null) {
-            getConnection().setBreakpoint(isolate, url, line, new VmCallback<VmBreakpoint>() {
-              @Override
-              public void handleResult(VmResult<VmBreakpoint> result) {
-                if (!result.isError()) {
-                  addCreatedBreakpoint(breakpoint, result.getResult());
-                }
-              }
-            });
+          // try package: URL
+          {
+            String url = getPackagesUrlForFilePath(filePath);
+            helper.setBreakpoint(url);
           }
-
-          if (file != null) {
-            url = getPackagesUrlForResource(file);
-          }
-
-          if (url != null) {
-            getConnection().setBreakpoint(isolate, url, line, new VmCallback<VmBreakpoint>() {
-              @Override
-              public void handleResult(VmResult<VmBreakpoint> result) {
-                if (!result.isError()) {
-                  addCreatedBreakpoint(breakpoint, result.getResult());
-                }
-              }
-            });
+          // try file:// URL
+          {
+            String url = getAbsoluteUrlForFilePath(filePath);
+            helper.setBreakpoint(url);
           }
         }
       }
 
       interruptResult.resume();
     } catch (IOException exception) {
       DartDebugCorePlugin.logError(exception);
     }
   }
 
@@ skipping 17 matching lines @@
       List<VmBreakpoint> breakpoints = entry.getValue();
       for (Iterator<VmBreakpoint> bpIter = breakpoints.iterator(); bpIter.hasNext();) {
         VmBreakpoint breakpoint = bpIter.next();
         if (breakpoint.getIsolate() == isolate) {
           bpIter.remove();
         }
       }
     }
   }
 
-  private String getAbsoluteUrlForResource(IFile file) {
-    return file.getLocation().toFile().toURI().toString();
+  private String getAbsoluteUrlForFilePath(String filePath) {
+    return new File(filePath).toURI().toString();
   }
 
   private VmConnection getConnection() {
     return target.getConnection();
   }
 
-  private String getPackagesUrlForResource(IFile file) {
-    String locationUrl = file.getLocation().toFile().toURI().toString();
+  private String getPackagesUrlForFilePath(String filePath) {
+    File javaFile = new File(filePath);
+    IFile resourceFile = ResourceUtil.getFile(javaFile);
+    if (resourceFile == null) {
+      return null;
+    }
+    String locationUrl = resourceFile.getLocation().toFile().toURI().toString();
 
     int index = locationUrl.indexOf(DartCore.PACKAGES_DIRECTORY_URL);
 
     if (index != -1) {
       locationUrl = DartCore.PACKAGE_SCHEME_SPEC
           + locationUrl.substring(index + DartCore.PACKAGES_DIRECTORY_URL.length());
 
       return locationUrl;
     }
 
     index = locationUrl.lastIndexOf(DartCore.LIB_URL_PATH);
 
     if (index != -1) {
-      String path = file.getLocation().toString();
+      String path = resourceFile.getLocation().toString();
       path = path.substring(0, path.lastIndexOf(DartCore.LIB_URL_PATH));
       File packagesDir = new File(path, DartCore.PACKAGES_DIRECTORY_NAME);
 
       if (packagesDir.exists()) {
-        String packageName = DartCore.getSelfLinkedPackageName(file);
+        String packageName = DartCore.getSelfLinkedPackageName(resourceFile);
 
         if (packageName != null) {
           locationUrl = DartCore.PACKAGE_SCHEME_SPEC + packageName + "/"
               + locationUrl.substring(index + DartCore.LIB_URL_PATH.length());
 
           return locationUrl;
         }
       }
     }
 
     return null;
   }
 
   private boolean supportsBreakpoint(IBreakpoint breakpoint) {
     return target.supportsBreakpoint(breakpoint);
   }
-
 }