Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 605763002: Add warning log when sysfs_power_monitor fail to read power frequency. (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add warning log when sysfs_power_monitor fail to read power frequency. BUG=416489 Committed: https://crrev.com/9426947d79353f001718473203b09defb147eaed Cr-Commit-Position: refs/heads/master@{#296727}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
6 years, 2 months ago (2014-09-25 15:42:12 UTC) #2
tonyg
lgtm https://codereview.chromium.org/605763002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/605763002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode112 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:112: 'Cannot read cpu frequency times in % s ...
6 years, 2 months ago (2014-09-25 15:50:19 UTC) #3
nednguyen
https://codereview.chromium.org/605763002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py (right): https://codereview.chromium.org/605763002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py#newcode112 tools/telemetry/telemetry/core/platform/power_monitor/sysfs_power_monitor.py:112: 'Cannot read cpu frequency times in % s due ...
6 years, 2 months ago (2014-09-25 15:54:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605763002/20001
6 years, 2 months ago (2014-09-25 15:54:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 71feb07056f7ab45d1b9d794aef2a18775270162
6 years, 2 months ago (2014-09-25 17:04:00 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 17:04:51 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9426947d79353f001718473203b09defb147eaed
Cr-Commit-Position: refs/heads/master@{#296727}

Powered by Google App Engine
This is Rietveld 408576698