Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 605743002: Revert of NaCl: Update revision in DEPS, r13759 -> r13770 (Closed)

Created:
6 years, 2 months ago by Mathieu
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbrazdil, Derek Schuff, David Yen, native-client-reviews_googlegroups.com, teravest
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13759 -> r13770 (patchset #1 id:1 of https://codereview.chromium.org/604483002/) Reason for revert: As noted, breaks goma builds. Original issue's description: > NaCl: Update revision in DEPS, r13759 -> r13770 > > This pulls in the following Native Client changes: > > r13760: (mseaborn) untrusted.gypi: Factor out duplicated "--gomadir" option > r13761: (mseaborn) Fix mmap() with length > 0xffff0000 to behave consistently on 32/64-bit > r13762: (teravest) Support file path metadata for the main nexe. > r13763: (teravest) Add CreateNaClDescWithFilePathMetadata fn. > r13764: (dschuff) Switch PNaCl lib, include, and translator directories for new layout > r13765: (dschuff) Pass naclsdk_validate=0 to scons runs run by main waterfall bots > r13768: (dbrazdil) Allowed decrementing program break with sbrk() in MinSFI > r13769: (dyen) Added tests for rename functions in irt_ext. > r13770: (dyen) Added tests for unlink functions irt_ext. > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg > TBR=dschuff@chromium.org > > Committed: https://crrev.com/a86ea9cb2d97183ae3080b7325bdc23e392ce96c > Cr-Commit-Position: refs/heads/master@{#296654} TBR=dschuff@chromium.org,sergeyv@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/b800d3d7756ecd316c1972dce7212cce672ab6d3 Cr-Commit-Position: refs/heads/master@{#296705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mathieu
Created Revert of NaCl: Update revision in DEPS, r13759 -> r13770
6 years, 2 months ago (2014-09-25 13:30:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605743002/1
6 years, 2 months ago (2014-09-25 13:30:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9c3d4d1b3e2e51134f90377f80cc921f110b355a
6 years, 2 months ago (2014-09-25 13:30:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b800d3d7756ecd316c1972dce7212cce672ab6d3 Cr-Commit-Position: refs/heads/master@{#296705}
6 years, 2 months ago (2014-09-25 13:31:25 UTC) #4
Mark Seaborn
6 years, 2 months ago (2014-09-25 16:46:25 UTC) #5
Message was sent while issue was closed.
LGTM for the record.

The issue is: https://code.google.com/p/chromium/issues/detail?id=417696

Powered by Google App Engine
This is Rietveld 408576698