PRESUBMIT.py - Issue 60573010: Make presumbit warnings ignore symbols that start with UNIT_TEST

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 60573010: Make presumbit warnings ignore symbols that start with UNIT_TEST (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: single if Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 2836a98e46eb79826de5090fa336beb0072320eb..33e13a580c8f9470c40c574e709d044cd6d0a72d 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -296,7 +296,7 @@ def _CheckNoUNIT_TESTInSourceFiles(input_api, output_api):

continue

for line_num, line in f.ChangedContents():

- if 'UNIT_TEST' in line:

+ if 'UNIT_TEST ' in line or line.endswith('UNIT_TEST'):

problems.append(' %s:%d' % (f.LocalPath(), line_num))

if not problems:

« no previous file with comments | « no previous file | no next file » | no next file with comments »